search

chef-boneyard / minitest-chef-handler

Run minitest suites after your Chef recipes to check the status of your system.
Other
163 stars 44 forks source link

Fixes issue 34: Invalid include. #40

Closed leifmadsen closed 12 years ago

leifmadsen commented 12 years ago

Resolves issue 34 by not directly including the MiniTest::Assertions module. Rather, we extend the usage of MiniTest::Assertions.

leifmadsen commented 12 years ago

Tested successfully.

Results with version 0.6.3:

Finished tests in 18.500030s, 0.3243 tests/s, 0.3784 assertions/s.

  1) Error:
test_0002_ensures_ssh_config_file_exists_with_correct_permissions(recipe::testing::default::files):
ArgumentError: wrong number of arguments (2 for 1)
    /var/chef/minitest/testing/default_test.rb:15:in `test_0002_ensures_ssh_config_file_exists_with_correct_permissions'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/handler.rb:226:in `run_report_unsafe'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/handler.rb:214:in `run_report_safely'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/handler.rb:93:in `run_report_handlers'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/handler.rb:92:in `each'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/handler.rb:92:in `run_report_handlers'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/handler.rb:103
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/client.rb:110:in `call'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/client.rb:110:in `run_completed_successfully'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/client.rb:109:in `each'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/client.rb:109:in `run_completed_successfully'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/client.rb:426:in `do_run'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/client.rb:176:in `run'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/application/solo.rb:230:in `run_application'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/application/solo.rb:218:in `loop'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/application/solo.rb:218:in `run_application'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/../lib/chef/application.rb:70:in `run'
    /usr/lib/ruby/gems/1.8/gems/chef-10.14.4/bin/chef-solo:25
    /usr/bin/chef-solo:19:in `load'
    /usr/bin/chef-solo:19

Results with this pull request:

Finished tests in 4.222982s, 1.4208 tests/s, 1.6576 assertions/s.

  1) Failure:
test_0002_ensures_ssh_config_file_exists_with_correct_permissions(recipe::testing::default::files) [/usr/lib/ruby/gems/1.8/gems/minitest-chef-handler-0.6.4/lib/minitest-chef-handler/resources.rb:41]:
The file does not have the expected owner.
Expected: "rot"
  Actual: "root"
leifmadsen commented 12 years ago

@acrmp if you don't mind, please review, but this change is basically exactly as you suggested.

@calavera Issue 34 is now resolved with this pull request. I also updated the History and gemspec file so as to avoid any warnings during gem build.

calavera commented 12 years ago

well done, sir!

I'm merging the commit and releasing the gem right away.

@leifmadsen, @acrmp I'm aslo going to give you push privileges so you can commit changes directly. I encourage you to still open pull requests to continue having awesome conversations like the one to fix this issue.

Cheers

acrmp commented 12 years ago

Excellent. Thanks guys!

leifmadsen commented 12 years ago

Indeed. Thanks!