search

chef-boneyard / minitest-chef-handler

Run minitest suites after your Chef recipes to check the status of your system.
Other
163 stars 44 forks source link

Please fix your dependency specifier ASAP #56

Closed zenspider closed 11 years ago

zenspider commented 11 years ago

Your unbounded dependency specifier on minitest is going to cause your gem to break in the future. See:

http://blog.zenspider.com/blog/2008/10/rubygems-how-to-preventing-catastrophe.html

calavera commented 11 years ago

Hi Ryan,

thank for taking your time opening the issue.

Since this is not a current problem, and we only had a minor compatibility problem with the minitest version shipped with ruby 1.9.2, I'm going to take my chances and leave it as it is now. I rather not be defensive and let people use the minitest version they want.

If we find any unsolvable compatibility problems in the future, I will fix the dependency specifier right away.

Thanks again.

zenspider commented 11 years ago

It isn't being defensive, it is being smart. My next release will break your library based on a quick glance at your code. You can use multiple specifiers to let people use any compatible version they want without breaking when I release.

calavera commented 11 years ago

Thanks Ryan,

I just saw this commit https://github.com/seattlerb/minitest/commit/9a57c520ceac76abfe6105866f8548a94eb357b6

That explains why I need to fix the dependency specifier much better than an old post :smile:

I will fix that tonight.