search

chef-boneyard / opscode-pushy-server

Chef Push Jobs Server
https://docs.chef.io/push_jobs.html
Apache License 2.0
16 stars 10 forks source link

[oc-pushy-pedant] Don't coerce heartbeat interval to int #138

Closed stevendanna closed 7 years ago

stevendanna commented 7 years ago

The heartbeat interval in pushy is in milliseconds. When coverting it to seconds we were inadvertantly converting it to an int. This made it impossible to, among other things, set up a test config with a heartbeat_interval < 1000ms.

marcparadise commented 7 years ago

:+1:

stevendanna commented 7 years ago

@smith I updated this, but I haven't looked at in a while to know if it is still relevant. But reading it over it seems reasonable to me.