search

chef-boneyard / opscode-pushy-server

Chef Push Jobs Server
https://docs.chef.io/push_jobs.html
Apache License 2.0
16 stars 10 forks source link

Remove typhoeus from oc-pushy-pedant #155

Closed stevendanna closed 7 years ago

stevendanna commented 7 years ago

typhoeus depends on libcurl at runtime. We would like to remove curl from the build. It appears that typhoeus is actually unused in the code so we can drop this dependency.

Signed-off-by: Steven Danna steve@chef.io

stevendanna commented 7 years ago

@rhass Ah, forgot to move that class. I believe that the tests are only really using EventStreamOld and EventStream isn't instantiated anywhere. If we'd prefer to keep the "EventStream" class then we'll need to re-add curl.

stevendanna commented 7 years ago

ad-hoc build: http://wilson.ci.chef.co/job/opscode-push-jobs-server-trigger-ad_hoc/33/downstreambuildview/

ksubrama commented 7 years ago

A lot of our curl based code seems to be old code to avoid the SSL cert issue we ran into with Ruby 2 years ago. Those are no longer an issue with a modern ruby and our omnibus builds. So +1 on dropping that class.