search

chef-boneyard / opscode-pushy-server

Chef Push Jobs Server
https://docs.chef.io/push_jobs.html
Apache License 2.0
16 stars 10 forks source link

ma/state wip 2 #43

Closed mpeck closed 11 years ago

mpeck commented 11 years ago

Make eunit pass

jkeiser commented 11 years ago

In general, the tests seem non-granular--shouldn't they have expectations on the exact number of intervals it should take before something goes up/down, and ensure that it doesn't happen until the exact time it needs to? Right now we sit around for n intervals (I'm not sure if they are long enough) and then just check at the end.

At any rate, that's not new to this and even if we decide to change it, should not block the patch.

Couple of questions to chat about, then MWR :)