search

chef-boneyard / opscode-pushy-server

Chef Push Jobs Server
https://docs.chef.io/push_jobs.html
Apache License 2.0
16 stars 10 forks source link

Fully decoupled pushy_node_state FSM start from command switch #50

Closed kevsmith closed 11 years ago

kevsmith commented 11 years ago

A deadlock could occur when the command switch started a node state FSM process in response to a pushy message. The deadlock happened because the command switch would block waiting on the supervisor to start the FSM process but the FSM process was sending command messages via the command switch.

This commit adds a "send after" capability to the command switch such that we can decouple the FSM from the switch at startup.

markan commented 11 years ago

Can we hold off on merging this logic since I've heavily churned the code as part of the command switch refactor?

jamesc commented 11 years ago

Just to note that this patch fixes the logic bug and I can now start up > 100 clients.

jkeiser commented 11 years ago

Fixed by something else.