OC-2196 Add error checking Pushy POST /jobs

chef-boneyard / opscode-pushy-server

Chef Push Jobs Server

https://docs.chef.io/push_jobs.html

Apache License 2.0

16 stars 10 forks source link

OC-2196 Add error checking Pushy POST /jobs #83

Closed mpeck closed 11 years ago

mpeck commented 11 years ago

Some error checking has already been done in previous work. This should top the rest off.

jkeiser commented 11 years ago

Some missing validation notwithstanding (could be addressed in a future patch), this looks good to go. Also, I think at least one test will fail.

mpeck commented 11 years ago

@jkeiser I refactored the validation a bit. It was a bit lax. Which test are you thinking will fail. I'm currently getting several failures, but thats on master of both pushy server and oc-pushy-pedant.

jkeiser commented 11 years ago

I was thinking the test with 0 nodes will fail (since you disallow that now :)

doubt72 commented 11 years ago

It does fail; we pulled it from the end-to-end tests and specifically test that case in the invalid POST body tests.