markan
commented
10 years ago Looks good to me on first, quick pass. Nice to see it getting some dialyzer attention; a lot of this stuff we let slide when doing the original work.
Closed christophermaier closed 10 years ago
markan
commented
10 years ago Looks good to me on first, quick pass. Nice to see it getting some dialyzer attention; a lot of this stuff we let slide when doing the original work.
jkeiser
commented
10 years ago This is awesome :) I found no problems in there and endorse checking it in.
This started out as ensuring that pushy had a standard OTP structure, but transformed a bit.
The first task was to get a modernized makefile in place. We used concrete for that.
The second task was to figure out whether or not we wanted to convert Pushy over to a flat directory structure or keep the 'apps' structure. We don't quite yet have hard-and-fast rules for this company-wide. Small tweaks to the concrete Makefiles can accommodate the nested structure, so I've opted to leave things as is for now.
Using concrete's dialyzer commands revealed that the command we were using for pushy was incorrect, uncovering loads of legitimate dialyzer errors. Most of this PR is concerned with fixing those.
In the end, Pushy is set for OTP, and it kind of always was.