chef-boneyard / push-jobs-cookbook

Development repository for Chef Cookbook push-jobs
https://supermarket.chef.io/cookbooks/push-jobs
Apache License 2.0
21 stars 43 forks source link

EL6 distros using runit instead of upstart #106

Closed andy-dufour closed 6 years ago

andy-dufour commented 7 years ago

Cookbook version

3.2.2

Chef-client version

12.14

Platform Details

RHEL & CentOS6

Scenario:

Use upstart as init provider.

Steps to Reproduce:

Install push jobs on CentOS or RHEL 6.

Expected Result:

The default init provider on EL6 distros is upstart, we should use it.

Actual Result:

Runit will be installed, instead of using an upstart based service.

andy-dufour commented 7 years ago

Have a rudimentary fix available: https://github.com/andy-dufour/push-jobs/tree/ad/el6_upstart

Default service provider on CentOS 6 resolves to sysvinit (Or chef::provider::service::redhat, which defaults to sysvinit), so I've had to explicitly set the provider to Upstart. Not great.

Open to other ideas. Going to rethink other options and look at adding some tests.

iennae commented 7 years ago

Re-reading the code, this looks to be a bug. This should detect and should be specific to the platform. Thanks for reporting!

iennae commented 7 years ago

Please take a look at version 5.0.0 of this cookbook. Upstart added its own complexities so there is a new sysvinit resource. The init script needs some polishing but let me know how this works for you.

tas50 commented 6 years ago

5.2.0 now uses Upstart on RHEL 6