Add windows and centos fix - Githubissues

chef-boneyard / push-jobs-cookbook

Development repository for Chef Cookbook push-jobs

https://supermarket.chef.io/cookbooks/push-jobs

Apache License 2.0

21 stars 43 forks source link

Add windows and centos fix #120

Closed iennae closed 7 years ago

iennae commented 7 years ago

Description

Add appveyor configuration testing.

Issues Resolved

[List any existing issues this PR resolves]

Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

tas50 commented 7 years ago

General idea of getting a sys-v resource added is super cool and getting the version stuff sorta out seems to be the right direction, but I'm not really the right person for that. I think you might want to hold off on worrying about the testing right now since that's a complex issue that will be a lot of work.