chef-boneyard / push-jobs-cookbook

Development repository for Chef Cookbook push-jobs
https://supermarket.chef.io/cookbooks/push-jobs
Apache License 2.0
21 stars 43 forks source link

Default to :latest version of push jobs (Chef 13 fix) #121

Closed mivok closed 7 years ago

mivok commented 7 years ago

Description

If you don't specify a version, it defaults to 'nil'. Until chef 13, this wasn't a problem, as it would result in the resource's default value of :latest being used. However, in Chef 13, this results in the version literally being set to nil, causing an error.

This change simply adds :latest as an explicit fallback option when setting the version to install.

https://docs.chef.io/deprecations_custom_resource_cleanups.html#nil-properties is the link to the deprecation, although it appears the issue addressed in this PR is slightly different, but results in the same warning and error.

Check List

iennae commented 7 years ago

Hi,

Thanks for the contribution. PR #120 has got the fix we are thinking of using. The underlying behavior of chef-ingredient if a version isn't sent will install latest.