chef-boneyard / push-jobs-cookbook

Development repository for Chef Cookbook push-jobs
https://supermarket.chef.io/cookbooks/push-jobs
Apache License 2.0
21 stars 43 forks source link

json_path not path and File.read #61

Closed thenoid closed 8 years ago

thenoid commented 8 years ago

https://github.com/chef-cookbooks/push-jobs/blob/master/libraries/helpers.rb#L87

'path' is a directory, 'json_path' is the json file

thenoid commented 8 years ago

So this and #57 are related

the full bugfix should be:

JSON.parse(File.read(json_path))['build_version']

JSON.parse doesn't appear to implement file reading.

markan commented 8 years ago

This should be fixed by PR #63

thenoid commented 8 years ago

thx! :+1: