search

chef-boneyard / vagrant-omnibus

A Vagrant plugin that ensures the desired version of Chef is installed via the platform-specific Omnibus packages.
Apache License 2.0
550 stars 63 forks source link

Quote the path to the MSI given to msiexec #117

Closed aogail closed 6 years ago

aogail commented 9 years ago

This way, spaces in the path will be correctly handled.

Without the quotes, msiexec hangs (presenting a GUI usage statement) if there are spaces in the path.

aogail commented 9 years ago

Is there anything I can do to get this merged?

rylarson commented 9 years ago

I really need this so that I can start using this plugin. This seems like a really low risk change. Can we get this merged?

chef-supermarket commented 8 years ago

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

Non-GitHub Verified Committers

There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.

Please sign the CLA here.

rylarson commented 8 years ago

Why did the CLA bot get involved a year after this was submitted?

tas50 commented 8 years ago

The CLA bot wasn't watching this repo. It's been turned on now.

chef-supermarket commented 8 years ago

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

rylarson commented 7 years ago

Bump?

tas50 commented 6 years ago

Sorry for the delay. Thanks