search

chef-boneyard / win32-sound

A Ruby library for playing and controlling sounds on MS Windows.
13 stars 3 forks source link

play_freq polishing #1

Closed domgetter closed 10 years ago

domgetter commented 10 years ago

I added some documentation on the waveout structs and also added some initialization methods with sensible defaults. An additional example was added for play_freq which shows how to make threads for simultaneous playback. I hope you don't mind, but I also set the Sound#beep example to play for only 2 seconds instead of 10. play_freq has an additional parameter for whether or not immediate playback is wanted. Hopefully this all looks good, let me know if you want anything different!

djberg96 commented 10 years ago

Looks good to me. Think it's ready for release?

domgetter commented 10 years ago

Yes I think so. I just pushed another commit to polish up the tests and consolidate constants with formatting to your liking. And as promised, I'll address any issues with the new functionality.

I've already started working on adding the rest of the waveout functions on a fork, along with some nifty callback functionality. It's not ready for prime time, but I'll keep you apprised and we can coordinate if/how to add it in.

djberg96 commented 10 years ago

Ok, I've released 0.6.0.