Changing the check to allow rules with the same name to use different…

chef-boneyard / windows_firewall

Chef cookbook to configure Windows Firewall

Apache License 2.0

6 stars 9 forks source link

Changing the check to allow rules with the same name to use different… #25

Closed SplinterHead closed 5 years ago

SplinterHead commented 7 years ago

… protocols

Some rules need to be added in tcp and udp, this change makes the check for existing rules more specific in that regard

sgtcoolguy commented 7 years ago

Just ran into this exact issue with Node.js where I wanted to allow both TCP and UDP inbound.

tas50 commented 6 years ago

@SplinterHead If you want to rebase this to the current codebase it would be nice to get this one in.

tas50 commented 5 years ago

I'm going to close this out since we never heard back from the author. If you're still interesting in this change please open a new PR that's been rebased.