search

chef-boneyard / windows_firewall

Chef cookbook to configure Windows Firewall
Apache License 2.0
6 stars 9 forks source link

Add remoteip and localip, plus additional style updates and include basic tests #4

Closed mattstratton closed 9 years ago

mattstratton commented 9 years ago

Couple things of note:

1) windows_batch replaced with the core primitive "batch", which has been supported since chef-client 11.6. 2) Test-kitchen support is still not fully functional (using the windows-guest-support branch, and I have not written all the tests or added all the platforms yet)

lynx44 commented 9 years ago

Looks good! What do you think about changing localip and remoteip to plural and making them array types? Seems like it might be a bit more intuitive to use IMO.

Looks like I can't automatically merge this pull request - how do you want to handle this? Can you pull this branch into your local repo and resolve the merge conflicts?

mattstratton commented 9 years ago

I think I can try to merge this branch into my version-2 branch, and then submit a new PR. Let me try that.

I'll start with that, get the merge nice and clean, and then submit a new PR that we can discuss. I have a few more changes I'm thinking about anyway :)

mattstratton commented 9 years ago

I merged but it is NOT stable yet. I am closing this PR and will submit a new one once I get everything tested.