Automated PR: Cookstyle Changes

[xorimabot]

Hey! I ran Cookstyle 6.2.9 against this repo and here are the results. This repo was selected due to the topics of cookbook

Changes

Issues found and resolved with examples/patch_by_flrtvc.rb

• 4:14 warning: Lint/SendWithMixinArgument - Use include AIX::PatchMgmt instead of send(:include, AIX::PatchMgmt).

Issues found and resolved with examples/update_by_suma.rb

• 4:14 warning: Lint/SendWithMixinArgument - Use include AIX::PatchMgmt instead of send(:include, AIX::PatchMgmt).

Issues found and resolved with examples/update_by_suma_latest.rb

• 4:14 warning: Lint/SendWithMixinArgument - Use include AIX::PatchMgmt instead of send(:include, AIX::PatchMgmt).

Issues found and resolved with examples/vios_altdisk_copy.rb

• 3:14 warning: Lint/SendWithMixinArgument - Use include AIX::PatchMgmt instead of send(:include, AIX::PatchMgmt).

Issues found and resolved with examples/vios_check.rb

• 2:14 warning: Lint/SendWithMixinArgument - Use include AIX::PatchMgmt instead of send(:include, AIX::PatchMgmt).

Issues found and resolved with examples/vios_update.rb

• 3:14 warning: Lint/SendWithMixinArgument - Use include AIX::PatchMgmt instead of send(:include, AIX::PatchMgmt).

Issues found and resolved with examples/vios_update_interactive.rb

• 3:14 warning: Lint/SendWithMixinArgument - Use include AIX::PatchMgmt instead of send(:include, AIX::PatchMgmt).

Issues found and resolved with libraries/lvmobj_fs.rb

• 90:9 convention: Style/RedundantReturn - Redundant return detected.
• 92:9 convention: Style/RedundantReturn - Redundant return detected.

Issues found and resolved with libraries/patch_mgmt.rb

• 655:19 convention: Style/HashEachMethods - Use each_key instead of keys.each.
• 657:26 convention: Style/HashEachMethods - Use each_key instead of keys.each.
• 719:19 convention: Style/HashEachMethods - Use each_key instead of keys.each.
• 721:26 convention: Style/HashEachMethods - Use each_key instead of keys.each.
• 899:31 convention: Style/HashEachMethods - Use each_key instead of keys.each.
• 946:36 convention: Style/HashEachMethods - Use each_key instead of keys.each.
• 1200:33 convention: Style/HashEachMethods - Use each_key instead of keys.each.
• 1296:12 convention: Style/HashEachMethods - Use each_key instead of keys.each.
• 1306:12 convention: Style/HashEachMethods - Use each_key instead of keys.each.
• 1309:12 convention: Style/HashEachMethods - Use each_key instead of keys.each.
• 1312:12 convention: Style/HashEachMethods - Use each_key instead of keys.each.
• 1317:14 convention: Style/HashEachMethods - Use each_key instead of keys.each.
• 1321:12 convention: Style/HashEachMethods - Use each_key instead of keys.each.
• 1716:39 convention: Style/HashEachMethods - Use each_key instead of keys.each.
• 1724:39 convention: Style/HashEachMethods - Use each_key instead of keys.each.

Issues found and resolved with libraries/storage_objects.rb

• 31:7 convention: Style/NegatedIf - Favor unless over if for negative conditions.
• 32:9 convention: Style/RedundantReturn - Redundant return detected.
• 33:7 convention: Style/EmptyElse - Redundant else-clause.
• 34:9 convention: Style/RedundantReturn - Redundant return detected.
• 41:9 convention: Style/RedundantReturn - Redundant return detected.
• 43:9 convention: Style/RedundantReturn - Redundant return detected.
• 80:7 convention: Style/NegatedIf - Favor unless over if for negative conditions.
• 83:9 convention: Style/RedundantReturn - Redundant return detected.
• 84:7 convention: Style/EmptyElse - Redundant else-clause.
• 85:9 convention: Style/RedundantReturn - Redundant return detected.
• 87:7 convention: Style/NegatedIf - Favor unless over if for negative conditions.
• 92:9 convention: Style/RedundantReturn - Redundant return detected.
• 93:7 convention: Style/EmptyElse - Redundant else-clause.
• 94:7 convention: Style/NegatedIf - Favor unless over if for negative conditions.
• 94:9 convention: Style/RedundantReturn - Redundant return detected.
• 101:7 convention: Style/NegatedIf - Favor unless over if for negative conditions.
• 101:9 convention: Style/RedundantReturn - Redundant return detected.
• 102:7 convention: Style/EmptyElse - Redundant else-clause.
• 103:9 convention: Style/RedundantReturn - Redundant return detected.
• 108:7 convention: Style/NegatedIf - Favor unless over if for negative conditions.
• 110:9 convention: Style/RedundantReturn - Redundant return detected.
• 111:7 convention: Style/EmptyElse - Redundant else-clause.
• 112:9 convention: Style/RedundantReturn - Redundant return detected.
• 126:7 convention: Style/NegatedIf - Favor unless over if for negative conditions.
• 130:9 convention: Style/RedundantReturn - Redundant return detected.
• 131:7 convention: Style/EmptyElse - Redundant else-clause.
• 132:9 convention: Style/RedundantReturn - Redundant return detected.
• 139:9 convention: Style/RedundantReturn - Redundant return detected.
• 140:7 convention: Style/EmptyElse - Redundant else-clause.
• 141:9 convention: Style/RedundantReturn - Redundant return detected.
• 153:9 convention: Style/RedundantReturn - Redundant return detected.
• 162:9 convention: Style/RedundantReturn - Redundant return detected.
• 176:9 convention: Style/RedundantReturn - Redundant return detected.
• 185:9 convention: Style/RedundantReturn - Redundant return detected.
• 196:7 convention: Style/NegatedIf - Favor unless over if for negative conditions.
• 203:7 convention: Style/NegatedIf - Favor unless over if for negative conditions.
• 210:7 convention: Style/NegatedIf - Favor unless over if for negative conditions.
• 211:9 convention: Style/RedundantReturn - Redundant return detected.
• 212:7 convention: Style/EmptyElse - Redundant else-clause.
• 213:9 convention: Style/RedundantReturn - Redundant return detected.
• 217:7 convention: Style/NegatedIf - Favor unless over if for negative conditions.
• 220:9 convention: Style/RedundantReturn - Redundant return detected.
• 221:7 convention: Style/EmptyElse - Redundant else-clause.
• 222:9 convention: Style/RedundantReturn - Redundant return detected.
• 229:7 convention: Style/NegatedIf - Favor unless over if for negative conditions.
• 229:9 convention: Style/RedundantReturn - Redundant return detected.
• 230:7 convention: Style/EmptyElse - Redundant else-clause.
• 231:9 convention: Style/RedundantReturn - Redundant return detected.
• 240:11 convention: Style/RedundantReturn - Redundant return detected.
• 242:11 convention: Style/RedundantReturn - Redundant return detected.
• 244:7 convention: Style/EmptyElse - Redundant else-clause.
• 245:9 convention: Style/RedundantReturn - Redundant return detected.
• 252:9 convention: Style/RedundantReturn - Redundant return detected.
• 253:7 convention: Style/EmptyElse - Redundant else-clause.
• 254:9 convention: Style/RedundantReturn - Redundant return detected.
• 261:9 convention: Style/RedundantReturn - Redundant return detected.
• 270:9 convention: Style/RedundantReturn - Redundant return detected.
• 283:9 convention: Style/RedundantReturn - Redundant return detected.
• 284:7 convention: Style/NegatedIf - Favor unless over if for negative conditions.
• 293:7 convention: Style/NegatedIf - Favor unless over if for negative conditions.
• 302:7 convention: Style/NegatedIf - Favor unless over if for negative conditions.
• 311:9 convention: Style/RedundantReturn - Redundant return detected.
• 312:7 convention: Style/EmptyElse - Redundant else-clause.
• 313:9 convention: Style/RedundantReturn - Redundant return detected.
• 322:9 convention: Style/RedundantReturn - Redundant return detected.
• 323:7 convention: Style/EmptyElse - Redundant else-clause.
• 324:9 convention: Style/RedundantReturn - Redundant return detected.
• 333:9 convention: Style/RedundantReturn - Redundant return detected.
• 334:7 convention: Style/EmptyElse - Redundant else-clause.
• 335:9 convention: Style/RedundantReturn - Redundant return detected.
• 342:9 convention: Style/RedundantReturn - Redundant return detected.
• 351:9 convention: Style/RedundantReturn - Redundant return detected.
• 365:9 convention: Style/RedundantReturn - Redundant return detected.
• 374:9 convention: Style/RedundantReturn - Redundant return detected.
• 383:9 convention: Style/RedundantReturn - Redundant return detected.

Issues found and resolved with libraries/tools.rb

• 39:9 convention: Style/RedundantReturn - Redundant return detected.
• 40:7 convention: Style/EmptyElse - Redundant else-clause.
• 41:9 convention: Style/RedundantReturn - Redundant return detected.

Issues found and resolved with providers/altdisk.rb

• 236:5 convention: Style/RedundantReturn - Redundant return detected.
• 242:7 convention: Style/RedundantReturn - Redundant return detected.
• 245:7 convention: Style/RedundantReturn - Redundant return detected.
• 268:5 convention: Style/RedundantReturn - Redundant return detected.

Issues found and resolved with resources/multibos.rb

• 20:1 refactor: ChefRedundantCode/UnnecessaryNameProperty - There is no need to define a property or attribute named :name in a resource as Chef Infra defines this on all resources by default.
• 20:1 convention: Layout/EmptyLines - Extra blank line detected.

Issues found and resolved with resources/nimclient.rb

• 382:7 convention: Style/RedundantReturn - Redundant return detected.

Issues found and resolved with resources/nimviosupdate.rb

• 205:18 convention: Style/HashEachMethods - Use each_key instead of keys.each.