search

chef-cookbooks / auditd

Install and configure user mode auditd tools
Apache License 2.0
34 stars 39 forks source link

CIS - Add Auditd.conf & Bug Fixes #48

Closed rmoles closed 5 years ago

rmoles commented 6 years ago

Fixes #47 Support has been added to update the auditd.conf to bring it in line with CIS specification. Files added as a result: cis.auditd.conf.erb, conf_file.erb, conf.rb

Changes have been made to the cis.rules.erb to fix failing Inspec controls.

welcomebot commented 6 years ago

Hey there. It's great to see you're interested in the Chef Cookbooks project. We're glad to have you as a contributor. Since this is your first time contributing I'm here to offer you a bit of extra help.

First please take a look at our contributing documentation at https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD#contribution-process. It covers the contribution process, how we review code, and how we release cookbooks. If you still have questions please come chat with us on the Chef Community Slack in the #cookbook-design room. We're always around to help with contributions.

rmoles commented 6 years ago

@tas50 Changes have been made based on comments. It would be good to get your opinion on this.

tas50 commented 5 years ago

My overall concern with this resource is what the end goal is. A resource that just drops off a file where the user doesn't control the content isn't really a resource. That's just a file/template in a recipe. If we were to fast forward a year what does this resource offer to a user? How can they use / reuse it throughout their infrastructure? If the answer is that only this cookbook ever consumes it and we use it to drop off that single config then we should just do that in a recipe and save the extra code.