added provides to resources to add chef 16 compatability

chef-cookbooks / chef-ingredient

Primitives for managing Chef products and packages

https://supermarket.chef.io/cookbooks/chef-ingredient

Apache License 2.0

45 stars 54 forks source link

added provides to resources to add chef 16 compatability #263

Closed Stromweld closed 4 years ago

Stromweld commented 4 years ago

added provides line along with resource_name for chef 16 and backwards compatability

Description

chef-infra client 16 backwards compatability

Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

tas50 commented 4 years ago

I'm a bit confused that our automation in this repo didn't catch this one.

Also can you sign this off for the DCO @Stromweld

Stromweld commented 4 years ago

@tas50 Testing has a lot of issues due to the tmp breakage for windows kitchen bootstrapping and a deprecation in a test for latest cookstyle but would break compatability with chef 13&14 that's being run in the tests.

Not sure if you'd want to upgrade tests to chef client 15&16 or not ect..., would be happy to take a crack at fixing it up a little here if you'd like me to.

Stromweld commented 4 years ago

@tas50 this is ready for review when you have time

Stromweld commented 4 years ago

All tests finally passing

Stromweld commented 4 years ago

added back older OSs and all tests are passing so I believe this is ready now, barring further review findings.

tas50 commented 4 years ago

Nice stuff. Thanks @Stromweld