Update to Chef 12.5 custom resources

chef-cookbooks / chef_client_updater

Chef Cookbook to update the chef client on nodes

https://supermarket.chef.io/cookbooks/chef_client_updater

Apache License 2.0

54 stars 79 forks source link

Update to Chef 12.5 custom resources #235

Closed detjensrobert closed 3 years ago

detjensrobert commented 3 years ago

Signed-off-by: Robert Detjens detjensrobert@osuosl.org

Description

Instead of using Chef 11 resource/providers, switch to Chef 12 custom resources. This also enables unified_mode for Chef 17 compatibility.

Issues Resolved

Fixes #217.

Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

tas50 commented 3 years ago

Sadly I'm going to have to close this out. We have a large number of folks trying to use this today to migrate off pre-12.5 releases. It's sad, but the reality we have.

jeffbyrnes commented 3 years ago

@tas50 wouldn't those folks be able to stick with an older version of this cookbook to do those migrations?

detjensrobert commented 3 years ago

What's the plan for unified_mode Chef 17/18 compatibility with this cookbook if this PR is closed? Does unified_mode work with the legacy LWRPs?

tas50 commented 3 years ago

@detjensrobert We can make it work only on systems with unified mode.

jeffbyrnes commented 3 years ago

@tas50 wouldn’t folks be able to pin to a version that works w/ Chef < 12.5 to use it to migrate? Or am I missing something?

tas50 commented 3 years ago

@jeffbyrnes We're trying to build a single cookbook for all releases and pre-12.9 (when custom resources really worked reliably) is a pretty common upgrade path for customers. This cookbook maintains compatibility all the way back to 11.x for that reason.

jeffbyrnes commented 3 years ago

Ok, makes sense! Thanks.

lamont-granquist commented 3 years ago

unified_mode false if defined?(:unified_mode) is probably the way to solve this