Disable unified_mode if present

chef-cookbooks / chef_client_updater

Chef Cookbook to update the chef client on nodes

https://supermarket.chef.io/cookbooks/chef_client_updater

Apache License 2.0

54 stars 79 forks source link

Disable unified_mode if present #238

Closed detjensrobert closed 2 years ago

detjensrobert commented 3 years ago

Signed-off-by: Robert Detjens detjensrobert@osuosl.org

As recommended instead of #235.

Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

ramereth commented 3 years ago

I'm confused, can't we go ahead and set this to true if the systems support it? I wasn't sure why @lamont-granquist suggested this be set to false

damacus commented 3 years ago

I'm confused, can't we go ahead and set this to true if the systems support it? I wasn't sure why @lamont-granquist suggested this be set to false

We probably want the same behaviour pre and post unified mode (aka we always want unified mode off). This does sort of break if we're upgrading from 18. But that's future us' problem.