chef-cookbooks / chef_client_updater

Chef Cookbook to update the chef client on nodes
https://supermarket.chef.io/cookbooks/chef_client_updater
Apache License 2.0
54 stars 79 forks source link

Switch unified_mode to resource not provider #240

Closed EMH333 closed 2 years ago

EMH333 commented 2 years ago

unified_mode needs to be enabled for the resource, not provider. This correctly fixes the deprecation error in Chef 17.

Works as expected with OSL's base cookbook

Check List

lamont-granquist commented 2 years ago

No, it isn't appropriate to do that with a true since now the behavior of the cookbook will be different on old chef-client 12.x which this cookbook still needs to support.

This needs a flag engineered specifically for this cookbook and pretty much only this cookbook which doesn't exist yet.

lamont-granquist commented 2 years ago

See:

https://github.com/chef/chef/pull/12502

and

https://github.com/chef/cookstyle/issues/936