search

chef-cookbooks / chef_client_updater

Chef Cookbook to update the chef client on nodes
https://supermarket.chef.io/cookbooks/chef_client_updater
Apache License 2.0
54 stars 79 forks source link

Support upgrading of CINC Client #252

Open mrswadge opened 1 year ago

mrswadge commented 1 year ago

Description

The directory name is incorrect when upgrading CINC. This change fixes the path.

This change is coupled with https://github.com/chef/mixlib-install/pull/389.

Related Issues

https://github.com/chef-cookbooks/chef_client_updater/issues/228 https://github.com/chef/mixlib-install/issues/339 https://github.com/chef-cookbooks/chef_client_updater/issues/249

Check List

mrswadge commented 1 year ago

Each time I sign off the commit, it's adding a new merge remote commit. Any idea how to stop that?

dkowis commented 8 months ago

I would super like to have cinc-client upgrades work :D

mrswadge commented 8 months ago

The issue affects very old cinc-client versions (we're on 15.6.10 and upgrading to 18.3.0), so the maintainers opted not to take the changes, which is their decision.

If you take the code changes I have suggested in this PR and also the mixlib changes mentioned too, then the upgrade can work. I've put my custom mixlib into an artifactory instance and so that's been enough for me to make progress.

dkowis commented 8 months ago

Oh that's interesting. I'm on cinc-client 18.3.0 and it didn't cooperate. I got the same error from https://github.com/chef-cookbooks/chef_client_updater/issues/249 and I thought this was still the solution... Maybe it's not related to this, but more on that other one.

mrswadge commented 8 months ago

There is a product matrix in mixlib that needed updating to add cinc which is what my pull request to mixlib added: https://github.com/chef/mixlib-install/pull/389

See this specifically: https://github.com/chef/mixlib-install/pull/389/files#diff-860efd9d5bfa21f0570091e1f7311509857b47def4905b6c8f76b283950f2a8cR50