Expand allowed data types for rule properties

bmhughes commented 4 years ago

Description

Allow rule.ip_version to accept a symbol or string
Allow rule.protocol to accept a symbol/string/integer

The current rule resource can't be trivially wrapped from role node attributes as you need to pass a symbol to ip_version and protocol, also protocol numbers are unable to be used.

As the resulting string is built from string interpolation anyway I can't see an issue in allowing more data types to be used.

Issues Resolved

n/a

Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

tas50 commented 4 years ago

@bmhughes can you rebase this. You can leave out the version bump too. Our tooling handles that.

bmhughes commented 4 years ago

Done

tas50 commented 4 years ago

This makes life a bit easier. Thanks

chef-cookbooks / iptables