chef-cookbooks / iptables

Development repository for Chef Cookbook iptables
https://supermarket.chef.io/cookbooks/iptables
Apache License 2.0
102 stars 141 forks source link

iptables_load wrapper does not obey iptables-restore exit status #114

Closed joseluis-fw closed 3 years ago

joseluis-fw commented 4 years ago

Cookbook version

6.0.1

Chef-client version

14.14.29

Platform Details

Debian Jessie

Scenario

Add a wrong iptables line

Steps to Reproduce

Add a wrong iptables_rule and run Chef and execute /etc/network/if-pre-up.d/iptables_load succeeds even the command would give a syntax error.

Expected Result

iptables_load obeys the iptables-restore exit status

Actual Result

iptables_load always return 0

welcomebot commented 4 years ago

Hey There It looks like this is the first issue you've filed against the chef-cookbooks project. I'm here to offer you a bit of extra help to make sure we can quickly get back to you. Make sure you've filled out all the fields in our issue template. Make sure you've provided us with the version of chef-client you're running, your operating system and the version of the cookbook. If you're not using the most up to date version of the cookbook then please make sure to update first. Lots of things change between versions even if you're issue isn't listed in the changelog. Finally please give us a detailed description of the issue you're having. The more we know about what you're trying to do, what actually happens, and how you can reproduce the problem, the better.

If you're looking for more immediate troubleshooting help make sure to check out #general on the Chef Community Slack. There's plenty of folks there willing to lend a helping hand. Thanks for the first issue. We hope we can get back to you soon with a solution.

xorima commented 3 years ago

Hi,

We have since released version 7, I am going to close this but if you still an the issue on version 7 please can you re-open this or open a new issue :+1:

Thanks