Comments with Spaces cause failure - Githubissues

chef-cookbooks / iptables

Development repository for Chef Cookbook iptables

https://supermarket.chef.io/cookbooks/iptables

Apache License 2.0

102 stars 141 forks source link

Comments with Spaces cause failure #120

Closed xorima closed 4 years ago

xorima commented 4 years ago

Description

Fixes issue where comments with a space were not quoted and would cause iptables to fail to start

Fixed rule resource
Added test to ensure it will not break again

Signed-off-by: Jason Field jason@avon-lea.co.uk

Issues Resolved

Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[X] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[X] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

xorima commented 4 years ago

@tas50 / @robbkidd could we get this one merged and shipped as it is causing breaks in my environment.

Also it would be great if travis was not a required check anymore ... :+1: