search

chef-cookbooks / iptables

Development repository for Chef Cookbook iptables
https://supermarket.chef.io/cookbooks/iptables
Apache License 2.0
102 stars 141 forks source link

Remove the FQDN from the config file #127

Closed ziggythehamster closed 3 years ago

ziggythehamster commented 3 years ago

Description

This is a simple/obvious change that removes the FQDN from the config file.

Issues Resolved

I made this change because we use chef-zero to build AMIs. The FQDN in the file is inaccurate, as it's the FQDN of the build box, and should Chef be re-run on the running box, a change is generated in this file for the comment only. This results in an unexpected change to the resource. It also triggers a restart of iptables, which would erase any transient rules like those created by Docker. I don't think the FQDN adds any value here, and so removed it.

I don't think the developer certificate of origin applies here, but if it does, I release this change into the public domain.

ziggythehamster commented 3 years ago

I should also add: I forked this from the latest release.