chef-cookbooks / iptables

Development repository for Chef Cookbook iptables
https://supermarket.chef.io/cookbooks/iptables
Apache License 2.0
102 stars 141 forks source link

Check subcmd exit codes in rebuild-iptables script #65

Closed JCotton1123 closed 7 years ago

JCotton1123 commented 8 years ago

Description

Ensures rebuild-iptables does actually succeed by checking subcommand exit codes.

Issues Resolved

https://github.com/chef-cookbooks/iptables/issues/64

JCotton1123 commented 7 years ago

I see that you're planning to replace this script. I am wondering if I should close this PR however it might make sense to merge it b/c 1) it may be a while before the rewrite happens, 2) the rewrite is likely going to require a major version bump and it may be a while before its widely adopted. Feel free to close this PR if appropriate.