Closed poblahblahblah closed 7 years ago
I should note that there were test failures, although these failures were already happening before my changes were applied.
Failures:
1) Service "iptables" should be installed
Failure/Error: it { should be_installed }
NotImplementedError:
check_is_installed is not implemented in Specinfra::Command::Redhat::V7::Service
# /tmp/verifier/gems/gems/specinfra-2.66.6/lib/specinfra/command_factory.rb:20:in `get'
# /tmp/verifier/gems/gems/specinfra-2.66.6/lib/specinfra/runner.rb:26:in `run'
# /tmp/verifier/gems/gems/specinfra-2.66.6/lib/specinfra/runner.rb:13:in `method_missing'
# /tmp/verifier/gems/gems/serverspec-2.38.0/lib/serverspec/type/service.rb:14:in `installed?'
# /tmp/verifier/gems/gems/serverspec-2.38.0/lib/serverspec/matcher/be_installed.rb:6:in `block (2 levels) in <top (required)>'
# /tmp/verifier/suites/serverspec/disabled_spec.rb:7:in `block (2 levels) in <top (required)>'
Finished in 0.04727 seconds (files took 0.23643 seconds to load)
10 examples, 1 failure
Failed examples:
rspec /tmp/verifier/suites/serverspec/disabled_spec.rb:7 # Service "iptables" should be installed
@tas50 Pinging you since you dealt with a similar PR in https://github.com/chef-cookbooks/iptables/pull/71
ping
ping
@tas50 is there a specific reason not reacting to this PR in any form? kind of wondering..
I just got missed in the volume of PRs / issues I get. I get about 200 e-mails a day so I miss a lot of valid stuff.
thx for taking time @tas50 and merging it.
Description
Issues Resolved
https://github.com/chef-cookbooks/iptables/issues/69
Check List