chef-cookbooks / iptables

Development repository for Chef Cookbook iptables
https://supermarket.chef.io/cookbooks/iptables
Apache License 2.0
102 stars 141 forks source link

Add sensitive option to resources #95

Closed bmhughes closed 5 years ago

bmhughes commented 5 years ago

Description

Senstive resource property added to resources to pass through to underlying template and file resources in rule and rule6 to prevent the contents of rule files being logged or output to the console.

Issues Resolved

Check List

bmhughes commented 5 years ago

Done, removed.

Interestingly is that documented anywhere? As I never realised this before and I can probably remove it from several internal wrapper cookbooks as well. Is it just the sensitive property that is inherited?

I've double checked the custom resource doc page but unless I'm missing it it doesn't seem to be mentioned.

bmhughes commented 5 years ago

I've also realised that the generate rule files are world readable so I've added and option to change the mode of the generated files as well. It defaults to the original functionality.

tas50 commented 5 years ago

Looks good now. Thanks