search

chef-cookbooks / runit

Development repository for the Chef Runit Cookbook
https://supermarket.chef.io/cookbooks/runit
Apache License 2.0
107 stars 197 forks source link

#60 in docker better rebased #171

Closed xmik closed 8 years ago

xmik commented 8 years ago

The discussion is in PR #148

coderanger commented 8 years ago

I think you went too far in the opposite direction. Using ps is okay, or at least better than implementing it yourself. My concern was you were parsing its output in Bash instead of in Ruby and generally not using the correct mixlib-shellout helpers (ex. error?).

xmik commented 8 years ago

@coderanger, I see. So do you want me to change this to using ps with mixlib-shellout but still avoid grep? Or do you need to apply more changes anyway?

cwjohnston commented 8 years ago

Closing in favor of #193