chef-cookbooks / runit

Development repository for the Chef Runit Cookbook
https://supermarket.chef.io/cookbooks/runit
Apache License 2.0
107 stars 197 forks source link

pin chef at ~> 12.5.0 in Gemfile to fix ChefSpec errors #185

Closed cwjohnston closed 8 years ago

cwjohnston commented 8 years ago

Seeing the following in chefspec tests after running bundle update. Pinning chef to ~> 12.5.0 makes it go away.

================================================================================
Recipe Compile Error in /var/folders/y4/ccjrk8mn4c74ynp2lc7kpnm80000gn/T/d20160318-99732-khya9u/runit_test/recipes/service.rb
================================================================================

ArgumentError
-------------
wrong number of arguments (1 for 0)

Cookbook Trace:
---------------
  /var/folders/y4/ccjrk8mn4c74ynp2lc7kpnm80000gn/T/d20160318-99732-khya9u/runit/recipes/default.rb:20:in `from_file'
    /var/folders/y4/ccjrk8mn4c74ynp2lc7kpnm80000gn/T/d20160318-99732-khya9u/runit_test/recipes/service.rb:20:in `from_file'

Relevant File Content:
----------------------
/var/folders/y4/ccjrk8mn4c74ynp2lc7kpnm80000gn/T/d20160318-99732-khya9u/runit/recipes/default.rb:

 13:  # Unless required by applicable law or agreed to in writing, software
 14:  # distributed under the License is distributed on an 'AS IS' BASIS,
 15:  # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 16:  # See the License for the specific language governing permissions and
 17:  # limitations under the License.
 18:  #
 19:
 20>> service 'runit' do
 21:    action :nothing
 22:  end
 23:
 24:  execute 'start-runsvdir' do
 25:    command value_for_platform(
 26:      'debian' => { 'default' => 'runsvdir-start' },
 27:      'ubuntu' => { 'default' => 'start runsvdir' },
 28:      'gentoo' => { 'default' => '/etc/init.d/runit-start start' }
 29:    )
cwjohnston commented 8 years ago

@luckymike @martinisoft care to validate this? I'm still unsure about the underlying cause.

luckymike commented 8 years ago

Tried to test this, but doing a bundle update pins me back to 12.3...

luckymike commented 8 years ago

Okay, I think the bundle update thing was a symptom of a Ruby Gems service degradation. I see this with 12.8.1, and this pin to 12.5.1 works for me.