chef-cookbooks / runit

Development repository for the Chef Runit Cookbook
https://supermarket.chef.io/cookbooks/runit
Apache License 2.0
107 stars 197 forks source link

Source repo should be configurable instead of hardcoded to packagecloud #204

Closed vinyar closed 7 years ago

vinyar commented 8 years ago

Cookbook version

3.0.0

Chef-client version

12.14

Platform Details

workflow vanilla environment node bootstrap in air gapped env

Scenario:

install push jobs client via delivery-base cookbook in air gapped environment

Steps to Reproduce:

add delivery base to runlist. it'll fail on attempting to configure package cloud because it cant reach outside.

Expected Result:

a way to install runit in air-gapped env

Actual Result:

have to fork the cookbook to get going.

tas50 commented 8 years ago

Any chance you can get a PR for this @vinyar

tas50 commented 7 years ago

The default recipe simply sets up package cloud and installs the package. If the user needs to use their own repo it's best that they write their own recipe to install runit. The complexity of handling multiple repos would be more than just writing the wrapper.

vinyar commented 7 years ago

The original bug was about an LWRP that had package cloud repo hardcoded. Looks like the current version doesn't do that. So 👍

tas50 commented 7 years ago

Oh yes the inclusion of the default recipe is gone now.