Also install the runit-systemd package on newer Ubuntus

chef-cookbooks / runit

Development repository for the Chef Runit Cookbook

https://supermarket.chef.io/cookbooks/runit

Apache License 2.0

106 stars 197 forks source link

Closed hartmantis closed 6 years ago

hartmantis commented 6 years ago

Looks like it was introduced in 17.10.

With this addition, the cookbook now converges successfully on the prerelease 18.04 builds.

Signed-off-by: Jonathan Hartman j@hartman.io

Cookbook fails to converge in Ubuntu 18.04 due to lacking a Systemd config.

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

hartmantis commented 6 years ago

Four of the build jobs failed, but it seems to be unrelated.

Two couldn't resolve the DNS for PackageCloud. If Travis showed a rebuild button to the PR submitter, I'd click it.

CentOS 6/Chef 12 failed because 12.7.2 didn't have the yum_repository resource yet.

FoodCritic is unhappy about the use of use_inline_resources.

Is it time to drop Chef 12 compatibility? Or just bump the chef_version to >= 12.15 to get yum_repository back?

tas50 commented 6 years ago

Thanks for the test