Quoting the timeout value prevents it being cast to an unsigned long. - Githubissues

chef-cookbooks / runit

Development repository for the Chef Runit Cookbook

https://supermarket.chef.io/cookbooks/runit

Apache License 2.0

106 stars 197 forks source link

Quoting the timeout value prevents it being cast to an unsigned long. #234

Closed bangpound closed 6 years ago

bangpound commented 6 years ago

Description

When the timeout value is quoted, runit passes this value to scan_ulong which looks for numerals 0 to 9 only.

Without this change, sv respects has a timeout of zero regardless what is set in the runit_resource's sv_timeout property.

Obvious fix.

Issues Resolved

[List any existing issues this PR resolves]

Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

tas50 commented 6 years ago

Thanks