Fixing plat_specific_sv_name logic + to work with Amazon Linux 2

jonthebastard commented 6 years ago

Description

Amazon Linux 2 uses systemd as opposed to Upstart; this change fixes the logic so that the recipe properly recognizes AL2:

Version 7 of imeyer/runit will be installed (confirmed that runit-2.1.2-3.el7.centos.x86_64.rpm does indeed work on AL2 + creates the necessary runsvdir-start.service file)
Use runsvdir-start for plat_specific_sv_name when using AL2
Only use Upstart on Amazon versions that are not AL2 (and/or RHEL 6)

Issues Resolved

Installs correct runit package that is compatible with Amazon Linux 2 and uses the correct plat_specific_sv_name in order to start runsvdir via systemctl.

Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

tas50 commented 6 years ago

Nice stuff. In the future you can skip the version bump since I have tooling that handles that and it causes merge conflicts a lot.

jonthebastard commented 6 years ago

Noted -- thank you for the info!

chef-cookbooks / runit