chef-cookbooks / runit

Development repository for the Chef Runit Cookbook
https://supermarket.chef.io/cookbooks/runit
Apache License 2.0
107 stars 197 forks source link

Rewrite the resource to use the Chef provides DSL #241

Closed tas50 closed 5 years ago

tas50 commented 5 years ago

The current resource is broken in Chef 15 because it inherits from Chef's service resource in a way that is entirely dependent on that resources implementation. We refactored service in Chef 15 and runit_service needs to be updated to decouple it from the underlying service resource.

tas50 commented 5 years ago

@lamont-granquist This seems to still be broken

-----> Starting Kitchen (v1.24.0)
-----> Converging <service-ubuntu-1604>...
       Preparing files for transfer
       Preparing dna.json
       Resolving cookbook dependencies with Berkshelf 7.0.7...
       Removing non-cookbook files before transfer
       Preparing validation.pem
       Preparing client.rb
-----> Chef Omnibus installation detected (install only if missing)
       Transferring files to <service-ubuntu-1604>
       Starting Chef Client, version 14.10.9
       resolving cookbooks for run list: ["runit_test::service"]
       Synchronizing Cookbooks:
         - runit_test (1.0.1)
         - runit_other_test (1.0.0)
         - packagecloud (1.0.1)
         - yum-epel (3.3.0)
         - runit (4.3.1)
       Installing Cookbook Gems:
       Compiling Cookbooks...
       Recipe: runit_test::service
         * directory[/etc/sv/plain-defaults/env] action create (up to date)
         * file[/etc/sv/plain-defaults/env/ZAP_TEST] action create (up to date)
         * directory[/etc/sv/env-files/env] action create (up to date)
         * file[/etc/sv/env-files/env/ZAP_TEST] action create (up to date)
         Converging 63 resources

       Running handlers:
       [2019-02-02T04:42:48+00:00] ERROR: Running exception handlers
       Running handlers complete
       [2019-02-02T04:42:48+00:00] ERROR: Exception handlers complete
       Chef Client failed. 0 resources updated in 01 seconds
       [2019-02-02T04:42:48+00:00] FATAL: Stacktrace dumped to /tmp/kitchen/cache/chef-stacktrace.out
       [2019-02-02T04:42:48+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
       [2019-02-02T04:42:48+00:00] FATAL: Chef::Exceptions::ResourceNotFound: resource file[/tmp/notifier] is configured to notify resource service[plain-defaults] with action restart,           but service[plain-defaults] cannot be found in the resource collection. file[/tmp/notifier] is defined in           /tmp/kitchen/cache/cookbooks/runit_test/recipes/service.rb:179:in `from_file'