In `shell_out` method updated options hash to **options - Githubissues

chef-cookbooks / runit

Development repository for the Chef Runit Cookbook

https://supermarket.chef.io/cookbooks/runit

Apache License 2.0

106 stars 197 forks source link

In `shell_out` method updated options hash to **options #259

Open antima-gupta opened 2 years ago

antima-gupta commented 2 years ago

Description

Updated options to**options because Passing the keyword argument as the last hash parameter is deprecated .

Issues Resolved

Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

RajeshPaul38 commented 2 years ago

This is a very important fix for us. We are working on ruby and rails upgrade for 3 different repositories. But due to the incompatibility of runit with ruby 3 standards the upgrade is blocked. This needs to be merged on priority to unblock the upgrades of the repositories.