Ensure entry resource is idempotent

chef-cookbooks / ssh_known_hosts

Development repository for Chef Cookbook ssh_known_hosts

https://supermarket.chef.io/cookbooks/ssh_known_hosts

Apache License 2.0

72 stars 77 forks source link

Ensure entry resource is idempotent #15

Closed blt04 closed 10 years ago

blt04 commented 10 years ago

This replaces #14 and is another approach to #9.

This makes the ssh_known_hosts resource idempotent. The resource previously notified on every chef run, despite not making file changes.

This fixes the reporting issue and simplifies the provider:

Supports whyrun
Doesn't add unnecessary comments to the known_hosts file
Sorts and dedups known_hosts file

https://tickets.opscode.com/browse/COOK-3453

blt04 commented 10 years ago

This has gone through code review and has been in Fixed Reviewed state for almost a month. What are the next steps to get this landed? @sethvargo, any ideas?

sethvargo commented 10 years ago

@blt04 there's no need to go through and comment on every single cookbook pull request. We have a review and release process that is documented on our wiki.

someara commented 10 years ago

merged in 53e1960ab179369537fab006cb286d74d0dcf01a