search

chef / appbundler

Generate locked binstubs for ruby applications
Apache License 2.0
14 stars 10 forks source link

Added a switch to exclude bins #14

Closed jaym closed 8 years ago

jaym commented 9 years ago

Allowing appbundler to exclude bins. Once this is in, we can pass whatever we need to from omnibus.

As an example

bundle exec appbundler ~/workspace/chef ~/appbundled-bins --exclude chef-service-manager --exclude chef-solo
jaym commented 9 years ago

cc @opscode/client-engineers

lamont-granquist commented 9 years ago

biggest concern that i've got around this is that I want to be able to re-appbundle packages in installed artifacts sometime and I'd prefer that we do something like drop a .json turd in the apps directory that appbundler reads state from so that it can be re-run and it'll do the same thing. it's an edge condition right now, but i think we're going to run into more people wanting to hack on the code and re-appbundle without completely regenerating a new artifact (the old /opt/chef/embedded/bin/gem install use case) and we'll need this in the future.

danielsdeleo commented 9 years ago

@lamont-granquist that might be overkill, I think. Seems like the worst case scenario (assuming existing code) is you'd get an extra chef-windows-service.bat in /opt/chef/bin which is probably not a big deal.

lamont-granquist commented 9 years ago

yeah as long as the 'failure mode' (aka leaving the args off) is halfway sane.

lamont-granquist commented 8 years ago

@jaym seems like we don't really need this...