Ask rubygems if the gemspec is supported on the current platform

chef / appbundler

Generate locked binstubs for ruby applications

Apache License 2.0

14 stars 10 forks source link

Ask rubygems if the gemspec is supported on the current platform #8

Closed jaym closed 9 years ago

jaym commented 9 years ago

RUBY_PLATFORM was i368-msys32, gemspec was x86-msys32

danielsdeleo commented 9 years ago

How does the test work? Would it fail if we ran it on AIX?

jaym commented 9 years ago

yep, it would fail on aix

On Thu, Nov 6, 2014 at 1:53 PM, Dan DeLeo notifications@github.com wrote:

How does the test work? Would it fail if we ran it on AIX?

— Reply to this email directly or view it on GitHub https://github.com/opscode/appbundler/pull/8#issuecomment-62058227.

jaym commented 9 years ago

I may have gone a little crazy here

danielsdeleo commented 9 years ago

Overall, it's pretty good. I think we ought to add a comment explaining the heuristic we're using to prioritize gemspecs. Also, if we can use a totally fake platform/arch for the platform-specific gemspec, that would be preferable to using a moderately obscure platform that we intend to support in the future.

jaym commented 9 years ago

Checked the Gem platform code, looks like it will be fine to use a fake arch and platform. Also added more about the heuristic (it's under most_specific_gemspec)

danielsdeleo commented 9 years ago

:+1:

tyler-ball commented 9 years ago

:+1: