code changes in global and config_request files - Githubissues

chef / automate

Chef Automate provides a full suite of enterprise capabilities for maintaining continuous visibility into application, infrastructure, and security automation.

https://automate.chef.io/

Apache License 2.0

224 stars 111 forks source link

code changes in global and config_request files #8405

Open Aishwarya2001A opened 3 months ago

Aishwarya2001A commented 3 months ago

:nut_and_bolt: Description: What code changed, and why?

Added Nginx config for X-Forwarded-For Header

:chains: Related Resources

https://chefio.atlassian.net/browse/CHEF-9078

:+1: Definition of Done

Added Nginx config for X-Forwarded-For Header
Changed in automate-load-balancer
Changed in automate-cs-nginx
Made this configurable
Tested the changes and see if the source IP is being logged into Server log
Tested in Standalone

:athletic_shoe: How to Build and Test the Change

1) Components to rebuild :

rebuild components/automate-gateway/
rebuild components/automate-load-balancer/
rebuild components/automate-cli/
rebuild components/automate-deployment/
rebuild components/automate-cs-nginx/

2) Added the following conf to demo.toml file

[global.v1.nginx] http_include_x_forwarded_for = true

and patch using the following command:

chef-automate config patch demo.toml

3) sudo tail -f /var/log/access.log ( To check if source IP is being logged into Server logs)

:white_check_mark: Checklist

All PRs must tick these:

[x] I have read the CONTRIBUTING document.
[x] All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

[x] Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
[x] Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
[x] Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
[x] Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
[x] Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

[ ] Tests added/updated? (all new code needs new tests)
[ ] Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

:camera: Screenshots, if applicable

Services are up and running

Successfully the source IP is being logged into Server logs

Testing video

https://progresssoftware-my.sharepoint.com/personal/aaishwar_progress_com/_layouts/15/stream.aspx?id=%2Fpersonal%2Faaishwar%5Fprogress%5Fcom%2FDocuments%2FMicrosoft%20Teams%20Chat%20Files%2FX%2Dforwarded%2Dheader%2Emov&ga=1&referrer=StreamWebApp%2EWeb&referrerScenario=AddressBarCopiedShareExpControl%2Eview

netlify[bot] commented 3 months ago

Deploy Preview for chef-automate processing.

Name	Link
Latest commit	0a44b661b5a555962b63c26e04ddc875ae8d04ca
Latest deploy log	https://app.netlify.com/sites/chef-automate/deploys/66333f603048e70008dee1b6

sonarqube-for-infrastructure-prod[bot] commented 2 months ago

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information