Avoid downloading application to implement eject-media - Githubissues

chef / bento

Packer templates for building minimal Vagrant baseboxes for multiple platforms

Apache License 2.0

4.24k stars 1.12k forks source link

Avoid downloading application to implement eject-media #1529

Closed MBradbury closed 1 year ago

MBradbury commented 1 year ago

Avoid downloading application to implement eject-media.ps1.

Description

eject-media.ps1 is currently implemented using EjectVolumeMedia. For Windows VMs that do not have internet access at build time they will be unable to download and execute this tool. So this change implements ejecting media (Floppy disk drives and CD drives) using pure powershell.

Related Issue

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

Stromweld commented 1 year ago

love it, thanks for the contribution. I'll try to get it tested in the next couple of days and then get it merged.