chef / berkshelf

A Chef Cookbook manager
Other
2 stars 3 forks source link

Fix version string comparison for Minitar and uncomment install feature #32

Closed tpowell-progress closed 2 months ago

tpowell-progress commented 2 months ago

Description

Problem

❯ bundle update --conservative berkshelf
Warning: the running version of Bundler (2.2.33) is older than the version that created the lockfile (2.3.26). We suggest you to upgrade to the version that created the lockfile by running `gem install bundler:2.3.26`.
Fetching https://github.com/chef/berkshelf.git

[!] There was an error while loading `berkshelf.gemspec`: comparison of Gem::Version with String failed. Bundler cannot continue.

 #  from /Users/powell/.rbenv/versions/3.0.6/lib/ruby/gems/3.0.0/bundler/gems/berkshelf-cb35db3c8ac9/berkshelf.gemspec:42
 #  -------------------------------------------
 #
 >    if ruby_version >= "3.1"
 #      s.add_dependency "minitar",              "~> 1.0"

After pointing at this fix:

Using knife 17.10.162 from source at `../knife` and installing its executables
Using kitchen-inspec 2.5.2
Using berkshelf 8.0.12 (was 8.0.9) from https://github.com/chef/berkshelf.git (at tp/ruby-version-berkshelf@4400ffa)
Bundle updated!
Post-install message from minitar:
The `minitar` executable is no longer bundled with `minitar`. If you are
expecting this executable, make sure you also install `minitar-cli`.

Check List

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud