chef-cli does not check in its Gemfile.lock. This has a few benefits:
Chef Workstation becomes the only source of truth we have to maintain for the entire bundle of gems included in our user downloadable packages.
No longer need to maintain the Expeditor subscriptions to ensure this gem's dependencies are updated to the latest version.
Downsides:
Potentially we could release, EG, a chef-apply and chef-cli gem that have different locked dependencies on 1 gem (EG, chef). We do not discover this until we try to resolve the gems inside the Workstation bundle.
I recommend we decide 1 pattern (checked in Gemfile.lock or not) for both chef-apply and chef-cli and stick with that pattern. The benefits (less PR review) of not having a checked in Gemfile.lock seem to outweigh the potential downside of a dependency conflict popping up in Chef Workstation after we release Chef Apply.
Related Issue
N/A
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Chore (non-breaking change that does not add functionality or fix an issue)
Checklist:
[x] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
Description
chef-cli
does not check in itsGemfile.lock
. This has a few benefits:Downsides:
chef-apply
andchef-cli
gem that have different locked dependencies on 1 gem (EG,chef
). We do not discover this until we try to resolve the gems inside the Workstation bundle.I recommend we decide 1 pattern (checked in
Gemfile.lock
or not) for bothchef-apply
andchef-cli
and stick with that pattern. The benefits (less PR review) of not having a checked inGemfile.lock
seem to outweigh the potential downside of a dependency conflict popping up in Chef Workstation after we release Chef Apply.Related Issue
N/A
Types of changes
Checklist: