chef / chef-apply

The ad-hoc execution tool for the Chef ecosystem.
https://www.chef.sh/
Apache License 2.0
14 stars 14 forks source link

Target host's output should be logged at higher importance than debug #28

Closed karthanistyr closed 6 years ago

karthanistyr commented 6 years ago

Description

In lib/chef_apply/action/converge_target.rb, there is this code:

if c.exit_status == 0
        ChefApply::Log.debug(c.stdout)
        notify(:success)

I can't think of a useful case where we should require log level of debug to output the received log from the target host's run. Setting chef-apply's output to debug spits out a lot of unnecessary stuff whereas the target host's output is much more valuable.

I propose chef-apply uses Log.info instead, to reflect this higher importance of the target host output over the minutiae of the chef-apply run in itself.

Chef Apply Version

All versions up to 0.1.13, latest as of writing.

Platform Version

Arch Linux patched to latest as of writing.

Replication Case

In .chef-workstation/config.toml:

[log]
level = "info"

Run a recipe via chef-run myhost path/to/recipe.rb

Client Output

Stacktrace

N/A