Update hashie dependency from 2.1 to 3.4

chef / chef-vault-testfixtures

provides an RSpec shared context for testing Chef cookbooks that use chef-vault

Apache License 2.0

7 stars 10 forks source link

Update hashie dependency from 2.1 to 3.4 #15

Closed dwmarshall closed 8 years ago

dwmarshall commented 8 years ago

See #14 for a little bit of context.

My Ruby-fu is not strong enough to really know whether naively changing the hashie dependency breaks anything, but the tests pass.

Furthermore, my attempts to make my test environment think it was going to build a gem with a version 0.5.1 came to naught - see honest assessment of Ruby-fu above.

mbellomo commented 8 years ago

Any ETA on this getting merged in and released? Ran into this myself today. If I remove hashie 3.4.3 the issue goes away...but that's the wrong answer. This pull request likely fixes my issue.

thommay commented 8 years ago

hi @dwmarshall , thanks for the PR. In future, please don't change versions in a PR, but just submit the code change you want. I'll bump the hashie version and see about getting a release pulled together. Thanks again.