chef / chef-web-docs

All The Documentation
https://docs.chef.io
Other
131 stars 439 forks source link

Install Script Changes for Omnitruck Documents #4288

Open vviveksharma opened 1 month ago

vviveksharma commented 1 month ago

Description

Definition of Done

Issues Resolved

[List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant]

Related PRs

https://github.com/inspec/inspec/pull/7118 https://github.com/chef/chef-server/pull/3869

Check List

netlify[bot] commented 1 month ago

Deploy Preview for chef-web-docs ready!

Name Link
Latest commit 2f2b00d809e3ff1dee995c76414ebb5b4fdcd008
Latest deploy log https://app.netlify.com/sites/chef-web-docs/deploys/66ccc66df5d5cb00084af161
Deploy Preview https://deploy-preview-4288--chef-web-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

IanMadd commented 1 month ago

The InSpec and Server pages can't be edited here in the _vendor directory. Those are just dependency files, like a copy of Node package file. If those files are edited, they'll just be overwritten when any content is updated in the _vendor directory

The sources of those files are here:

Once those files are edited and merged there, they can be updated in this repo.

karunesh-tech commented 1 month ago

As per feedback from product - Sonia Arora(@sonarora) made changes in the draft documentation:

1/ Remove trial persona (only have commercial and community) 2/ Add the section to point to download portal 3/ Example of licenseId

karunesh-tech commented 1 month ago

The InSpec and Server pages can't be edited here in the _vendor directory. Those are just dependency files, like a copy of Node package file. If those files are edited, they'll just be overwritten when any content is updated in the _vendor directory

The sources of those files are here:

Once those files are edited and merged there, they can be updated in this repo.

@IanMadd Added changes as per above guidance:

https://github.com/inspec/inspec/pull/7118 https://github.com/chef/chef-server/pull/3869

karunesh-tech commented 3 weeks ago

@IanMadd All the comments are taken care, please review and approve the PR and based on the release plan as per @sonarora you can proceed to merge the changes in order to make it live. CC: @clintoncwolfe

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud