Add ChefZero::Dist to abstract branding details to a single location

Tensibai commented 5 years ago

Related to chef/chef's #8376 design proposal to set brands in a single location for easy patching by community distributions.

Description

Add a dist.rb file defining the PRODUCT and CLIENT constants to be used in outputs.
Replace occurences of chef-zero and Chef-Zero by their constant counterparts.
add a require "chef_zero/dist.rb" to files updated on point above

Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

tas50 commented 5 years ago

@Tensibai can you make sure all the commits have the DCO sign off?

Tensibai commented 5 years ago

To be extra complete, changes in rspec.rb and socketless_server_map.rb does change the output text/exception text to what was coherent in my mind, there's a possibility this breaks someone tests out there.

ramereth commented 5 years ago

@tas50 any update on when this will get merged?

chef / chef-zero