search

chef / chef

Chef Infra, a powerful automation platform that transforms infrastructure into code automating how infrastructure is configured, deployed and managed across any environment, at any scale
http://www.chef.io/chef/
Apache License 2.0
7.59k stars 2.51k forks source link

windows_feature is no longer case insensitive #7080

Closed tas50 closed 6 years ago

tas50 commented 6 years ago

This was a change that went out with the windows 4.0 cookbook with the rewrite of the resource to get it ready for inclusion into core Chef.

Background: Previously we took a string or array of features and simply tried to install them. If the user provided us with bogus features we just continued as if the features had been successfully installed. It was absolutely less than ideal since users want to know that what we tell them to do actually happens

With the rewrite of the resource we began tracking the available features, installed features, and removed (not to be confused with not installed) features. If the feature requested for installation didn't exist we failed.

This seems like the right thing to do, but the problem is the user can provide us with a feature like 'snmp' which is valid on the CLI, but doesn't match the available feature of 'SNMP'. So in 4.1.2 I downcased the requested and available features, which fixes the comparison and works great...except on Windows 2008 R2.

So we need to figure out a way to make this work, while still failing on win2k8r2. We should probably downcase only on modern Windows releases. This needs to get tested out in the cookbook and shipped in Chef 14.

tas50 commented 6 years ago

Fixed by #7079

lock[bot] commented 6 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.